Skip to content
Snippets Groups Projects
Select Git revision
  • 985008bfa4f175c5d884bfdc10e9825498e01986
  • master default protected
  • Exercise-5
  • 045-jpa-many-to-many
  • Exercise3
  • Exercise2
  • Exercise2b
  • 047-file-upload
  • 046-profiles
  • 044-adopt-JPA-for-domain
  • 041-jpa-hexagonal
  • 046-using-profiles-and-mariadb
  • 044-jpa-gotchas
  • 044-7
  • 044-6
  • 044-5
  • 044-4
  • 044-3
  • 044-2
  • 044-1
  • 043-jpa-hexagonal
  • 042-intro-jpql
  • 041-intro-jpa
  • 040-introduce-logging
  • 039-add-jdbc-tests
  • 038-add-mock-tests
  • 037-e2e-tests
  • 036-convert-test-to-sbtest
  • 035-update-to-db
  • 034-add-trustee-table
  • 033-extend-REST-api
31 results

service

  • Clone with SSH
  • Clone with HTTPS
  • Carl Jones's avatar
    Carl Jones authored
    The tests are now working again, and we've added some new ones.  We've also split the tests and the test data scripts.
    
    Things to think about:
    
    when is the data setup?
    what's the order of the tests?
    what is needed for the tests to run?
    which components are we testing or are we testing end-to-end?
    
    Thinking about the tests also helps us reconsider our design and the full contracts between components. The POST API should return a 201 response code and a header Location for the new charity.  This emphasises that the components have different concerns.  The service cares about coordinating the creation of a new charity in the domain.  The controller trusts the service to do that and it's concern is abiding by the REST standards.  Given this separation, maybe we could test the controllers in a different (and faster) way?
    3e397136
    History
    Code owners
    Assign users and groups as approvers for specific file changes. Learn more.
    Name Last commit Last update
    ..
    dto
    impl
    CharitySearch.java