Resolve "As a repeat trail visitor , I want to be able to create an account so I can save and review my progress."

Closes #70 (closed)

changed milestone to %Week 10 - Sprint 3

added To Do label

added 31 commits

• a9ddc9f2...2fc992e9 - 25 commits from branch main
• e5137b42 - Merge branch 'QRCodes' into 'main'
• f0481cca - Commit changed edit this later need for checkout
• 1ac09504 - Merge branch 'main' into...
• e847822d - Adjusted schema.sql to be more readable;
• c15217aa - Adjusted SQL queries to better protect from SQL injection
• f695ff76 - New Login page. Started work on the controllers. Currently one can create...

Compare with previous version

added 2 commits

• 96fd065d - Bugfixes
• 7ac4e7d6 - Client Side Javascript balidation for forms

Compare with previous version

added 32 commits

• 7ac4e7d6...70891095 - 31 commits from branch main
• a797ec6e - Merge branch 'main' into...

Compare with previous version

added 1 commit

• 739f4c54 - Added login validation with Spring Security

Compare with previous version

marked this merge request as ready

added Ready to Merge label and removed To Do label

Ready for approval. User can now create an account and login to the website. Currently only the user profile page is locked behind authentication. Password is not secure yet, that's the next User Story I will be working on.

requested review from @d1634883

assigned to @c23127194

added 2d of time spent

added 1 commit

• aba2121e - Added some comments and removed redundant database columns

Compare with previous version

added 2 commits

• 1e75ba6b - Added some comments and removed redundant database columns
• 9eb7587c - Merge remote-tracking branch...

Compare with previous version

Just checked over your code now, it looks impressive and reaches all tasks and assessment criteria, the only issue I found was that there is no ability for the user to log-off once logged in and that the sign-up verification is lacking verification to ensure that a new user doesn't create an account with the same name as an existing user, which causes an sql error.

added 2 commits

• 6d10e0ec - Brainstorming work for the next sprint
• 9564ad0d - Mobile phone layout for all trails page

Compare with previous version

Fixed the issues you mentioned. Should now be ready for merge if nothing else comes up

added 1 commit

• 33a78976 - Testing on merge request, failed tests require looking at

Compare with previous version

Hi, just checked your code out, when testing there appears to be an issue with users unlocking stickers from their pack within canUsersUnlockStickersTest() on testUsers.Java. When a valid sticker is unlocked for a valid user, the if statement within the unlockSticker() function does not return true following its internal if statement checking the sticker validity. Could you take a quick look if you have time, thanks

added 1 commit

• 90b36806 - Fixed reported issue with UnlockSticker method

Compare with previous version

Thanks for letting me know, there was an issue where the method was looking for ALL stickers in the table instead of just the one being unlocked. It is now fixed!

Thanks for the fix, I can confirm that its working great now, thanks.

Its all good, your merger meets all necessary tasks and assessment criteria, it runs without fault or conflicts. My only other suggestion is to add a header and footer to the user profile, or a home button (which would be a more visually appealing alternative). As it stands, after logging in the user must change the url to continue onto the site. Otherwise it's great and ready to merge.

Already on it in the next user story #77 (closed)

In that case, I'm happy to say your merger request is accepted.

added 1 commit

• aba00a33 - Updated test users name to allow test to run a one without same user insertion conflicts

Compare with previous version

approved this merge request

merged

mentioned in commit aa9507cc