Resolve "As a user I would like to see a map containing all landmarks for a trail and a suggested path between them, so that I can easily follow the trail"
Closes #68 (closed)
Merge request reports
Activity
changed milestone to %Week 10 - Sprint 3
added In Progress label
added 1 commit
- 98d03e94 - Added foreign key to trails table. Expanded on trails table.
added 1 commit
- b1ad6c24 - Further work on trails webpage, links added to individual loation page
added 1 commit
- 9daf5806 - Furtther work on trails list page / Junit testing
added 1 commit
- 94ea2461 - cleared cache, seems to fix xsome issues with Junit testing
added 1 commit
- b938dd7c - Rough final story-product of dynamic page showing a list of checkpoints per trail
requested review from @c23127194
Hi, I've been having trouble getting an embedded google maps iframe to show up on my /trails dynamic webpages, could you have a look and see if you can spot the problem? Thanks. I'd be happy to work on any other feedback you have for the current implementation of your story, as apart from this issue, I appear to be near completion for this user story.
Will have a look at the bugs you encountered. On the meanwhile, I've noticed that specific landmark pages do not have a back button to return to their respective trail pages and instead the user needs to type the URL to go back. Good functionality to have before I can accept the merge request.
Overall the code is very good:
- Good protection against SQL injections.
- I like the change from locationtrailID to being an arbitrary int to being the string name of the trail location.
- Code is easy to read and there are appropriate comments explaining where needed.
added 21 commits
-
49e762e6...aa9507cc - 19 commits from branch
main
- 0ef5141d - Merge branch 'main' into...
- 69dce865 - Additions to testing and streamlining code
-
49e762e6...aa9507cc - 19 commits from branch
added 1 commit
- 9356db39 - Further streamlining of trails controller code
added 1 commit
- 2fd0f99d - Added further testing, return buttons to lcoations pages and map alternative button
added Ready to Merge label
removed In Progress label
added 1 commit
- 2cf28210 - Added unauthorisedLocations test for future feature
mentioned in commit 6a4491e8